fix(txpool): move prevJ update outside sentryClients loop#18429
Merged
yperbasis merged 1 commit intoerigontech:mainfrom Dec 29, 2025
Merged
fix(txpool): move prevJ update outside sentryClients loop#18429yperbasis merged 1 commit intoerigontech:mainfrom
yperbasis merged 1 commit intoerigontech:mainfrom
Conversation
yperbasis
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in AnnouncePooledTxns where prevJ = j was inside the sentryClients loop.
If all sentry clients were skipped (not ready or protocol < 68), prevJ never got updated,
causing an infinite loop. Moved the assignment outside the loop to match PropagatePooledTxnsToPeersList behavior.